Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44108 )
Change subject: soc/intel/common: Include Alder Lake device IDs
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44108/3/src/include/device/pci_ids....
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/44108/3/src/include/device/pci_ids....
PS3, Line 2895: ADP
Add that name to the commit message too?
IMHO, it's not a big deal.
Plus, name clashes do exist: See `TGP` above, but `Tiger Point` is the codename of the NM10 chipset (usually paired with Pineview and Cedarview CPUs, more than a decade old): https://ark.intel.com/content/www/us/en/ark/products/codename/37533/tiger-po...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44108
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17ce56a220e4dce2db2e0e69561b3d6dac9e65a2
Gerrit-Change-Number: 44108
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Aug 2020 17:40:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment