Attention is currently required from: Maulik V Vaghela, Mario Scheithauer, Subrata Banik, Lean Sheng Tan, Patrick Rudolph.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54958 )
Change subject: soc/intel/elkhartlake: Update FADT table
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/soc/intel/elkhartlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/54958/comment/c4bbbe11_9526a792
PS3, Line 165: fadt->duty_width = 0x3; /* CLK_VAL bits 3:1 */
Hi Werner, dont worry the duty offset has been set in common codes, so i dont want to replicate agai […]
Oh, thanks for the clarification.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54958
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72a57bf8ec61c3eabc4522c2695ae4b16979f188
Gerrit-Change-Number: 54958
Gerrit-PatchSet: 3
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 27 May 2021 06:11:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Lean Sheng Tan
lean.sheng.tan@intel.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment