12 Nov
2021
12 Nov
'21
1:50 a.m.
Attention is currently required from: Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33398 )
Change subject: util/amdfwtool: Add multilevel PSP directory table ......................................................................
Patch Set 3:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/33398/comment/7f09b486_20e479c1 PS3, Line 255: { .type = AMD_FW_PSP_SMU_FIRMWARE, .subprog = 1, .level = PSP_BOTH }, : { .type = AMD_FW_PSP_SMU_FIRMWARE2, .subprog = 1, .level = PSP_BOTH }, those are duplicates of entries above. was this intended?
--
To view, visit https://review.coreboot.org/c/coreboot/+/33398
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id321f5142e461d4a7f3343c0835a09a1a1128728
Gerrit-Change-Number: 33398
Gerrit-PatchSet: 3
Gerrit-Owner: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Fri, 12 Nov 2021 01:50:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment