Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38639 )
Change subject: soc/intel/common/systemagent: add Kconfig guard ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38639/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38639/1//COMMIT_MSG@9 PS1, Line 9: Looks like having this in the tree force-sets MMCONF_BASE_ADDR to : some value which can't be overriden anywhe
there as discussion in https://review.coreboot.org/c/coreboot/+/38013 (force abandoned) […]
I am still confused how this change would help. If your platform is not in src/soc, then I assume you are not selecting SOC_INTEL_COMMON. If that is the case, then this check should fail: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/common/Kcon...
https://review.coreboot.org/c/coreboot/+/38639/2/src/mainboard/intel/harcuva... File src/mainboard/intel/harcuvar/Kconfig:
https://review.coreboot.org/c/coreboot/+/38639/2/src/mainboard/intel/harcuva... PS2, Line 45: config MMCONF_BASE_ADDRESS Instead of adding these to mainboard, I think it would be better to add these to soc/intel/denverton_ns/Kconfig