[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Split the "internal PME" wake-up into more detail

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34289 )

Change subject: soc/intel/cannonlake: Split the "internal PME" wake-up into more detail
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34289/1/src/soc/intel/cannonlake/el... 
File src/soc/intel/cannonlake/elog.c:

https://review.coreboot.org/c/coreboot/+/34289/1/src/soc/intel/cannonlake/el... 
PS1, Line 114: if (!dev_found)
             : 		dev_found = pch_xhci_update_wake_event(&usb_info);
             :
> Interesting... […]

The whole elog for S0ix is kind of Linux specific :). But again that is true for other parts of elog as well i.e. logging kernel shutdown, etc. i.e. it depends on the Linux kernel GSMI driver to make a call into SMI handler to allow it to log certain conditions.