Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54305 )
Change subject: util/ifdtool: Use -p platform name to detect IFDv2 platform and chipset
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
Before this change it auto-detected the descriptor of X11SSH-LN4F as IFDv2. […]
can you please let me know X11SSH-LN4F is belongs to which chipset and this CL haven't change anything related to what all chipsets belongs to IFDv2. here is the list of chipsets from IFDv2, https://review.coreboot.org/c/coreboot/+/54305/10/util/ifdtool/ifdtool.c#240
if your platform belongs to IFDv2 then -p should be used for correct detection. Else we assume its IFDv1.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54305
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25f69ce775454409974056d8326c02e29038ec8a
Gerrit-Change-Number: 54305
Gerrit-PatchSet: 10
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Jan Tatje
jan@jnt.io
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Mon, 05 Jul 2021 13:35:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jan Tatje
jan@jnt.io
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment