Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37814 )
Change subject: acpi: Change Processor ACPI Name (Intel only)
......................................................................
Patch Set 19:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37814/19//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37814/19//COMMIT_MSG@7
PS19, Line 7: acpi: Change Processor ACPI Name (Intel only)
'Intel only' and modifying three AMD files?
Removed the comments. Looks like it did just changed that comment everywhere.
https://review.coreboot.org/c/coreboot/+/37814/19/src/soc/intel/braswell/acp...
File src/soc/intel/braswell/acpi.c:
https://review.coreboot.org/c/coreboot/+/37814/19/src/soc/intel/braswell/acp...
PS19, Line 426: acpigen_write_processor(
No CRLF required, will fix in same line
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37814
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib101ed718f90f9056d2ecbc31b13b749ed1fc438
Gerrit-Change-Number: 37814
Gerrit-PatchSet: 19
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Mon, 23 Mar 2020 13:39:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Gerrit-MessageType: comment