EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46566 )
Change subject: mb/google/zork: Correct get board version and get fw config condition
......................................................................
Patch Set 5:
This based on if we know the return value 0 as success and otherwise failed. It's pretty common to use the below statement:
if (rv != 0)
return rv;
But I checked the chromeec/ec.c. Looks like there are no consistent rule on this coding style. Some people check '!= 0' some didn't. What's you prefer?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46566
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia49ac1ee35302f8f6afe8c0eb8e13afdf36c5b2b
Gerrit-Change-Number: 46566
Gerrit-PatchSet: 5
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 19 Oct 2020 21:35:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment