Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41918 )
Change subject: abuild: Fix board variant handling
......................................................................
Patch Set 1:
If we don't want to land this patch, we will have to put out a full "Documentation" [1] on abuild that we have to use this format:
eg. to build test asus/p5qpl-am/variants/p5g41t-m_lx/, one has to run:
$ util/abuild/abuild -t asus/p5qpl-am -b p5g41t_m_lx
Meanwhile substitution underscores for dashes for base target like p5qpl_am does not work.
[1] Yes, I mean add full documentation under Documentation/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41918
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10d5b471dac41c50a85c4a309ec561b02687bb9a
Gerrit-Change-Number: 41918
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 30 May 2020 16:33:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment