Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 11:
(6 comments)
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG@9 PS9, Line 9: Need tune DPTF insure it meets Akemi DPTF Spec
Tune DPTF to ensure compliance with Akemi DPTF specification.
Done
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG@9 PS9, Line 9: Spec
spec
Done
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG@9 PS9, Line 9: insure
ensure?
Done
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG@10 PS9, Line 10:
Dear Paul, sorry I am wrong, it's the thermal design requirements for Akemi.
Done
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... PS2, Line 47: DPTF_TSR2_CRITICAL
Done
Done
https://review.coreboot.org/c/coreboot/+/36716/10/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36716/10/src/mainboard/google/hatch... PS10, Line 139: 12000,
I'm still curious about this value. […]
Done