ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42947 )
Change subject: doc/mb/ocp: Add documentation for Delta Lake ......................................................................
Patch Set 1:
(7 comments)
Exciting stuff!
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/deltalake.md:
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp... PS1, Line 17: jointly develop FSP/coreboot/Linuxboot solution on Delta Lake as a hack project. I'd like a better word than hack. In fact, I would remove "as a hack project" words entirely.
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp... PS1, Line 51: kernel versions tried is 5.2.9. The initramfs image is u-root. version
is it worth adding u-root.org as a pointer when you mention u-root.
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp... PS1, Line 62: - Skipping memory training upon subsequent reboots fantastic.
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp... PS1, Line 67: [ChromeOS VPD] is used to store most of firmware configurations. RO_VPD most of the firmware configurations.
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp... PS1, Line 80: - ME based power capping. capping is ... what? not supported? ticket filed? Never will be supported?
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp... PS1, Line 88: | BMC | Aspeed AST 2500 | complete with the embedded well known password :-)?
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp... PS1, Line 94: [OCP]: https://www.opencompute.org nice links!