Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36300 )
Change subject: vboot: use vboot persistent context ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36300/2/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36300/2/src/security/vboot/common.c... PS2, Line 146: VB2_KERNEL_WORKBUF_RECOMMENDED_SIZE It'd be nice if we could know at this point how much extra we need for struct vboot_working_data + padding for 16-byte alignment... are we guaranteed that cbmem entries will be 16-byte aligned?
(Again, I think it'd be much simpler if the workbuf just lived in its own entry now...)