Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37400 )
Change subject: sb/amd/{agesa,pi}: use ACPIMMIO common block wherever possible
......................................................................
Patch Set 11:
Patch Set 8:
Patch Set 8:
Also got rid of __outbyte, __inbyte and __rdtsc
Hmmm.. can you put this back to #7 and make those separate ones.
FYI: That SMBUS might go away completely. From what I remember SMBUS host controller specification was not Intel proprietary and AMD implementation is compatible with the more complete one under southbridge/intel/common/smbus.
I will look closer at it then
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37400
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3d5abc8f3b235ea61f66950ada8aff1dc48f8c3
Gerrit-Change-Number: 37400
Gerrit-PatchSet: 11
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 03 Jan 2020 14:25:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment