[coreboot-gerrit] [L] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI

[Angel Pons (Code Review)]

Attention is currently required from: Christian Walter, Lean Sheng Tan, [e-mail].

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 )

Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI
......................................................................

Patch Set 1:

(2 comments)

Patchset:

PS1: 
Would be nice to make the build bot happy

File src/mainboard/prodrive/atlas/emi.c:

https://review.coreboot.org/c/coreboot/+/68137/comment/208566cc_a458907c 
PS1, Line 15: #define EMI_1_BASE EMI_0_BASE + APPLICATION_ID + 0x1
> Macros with complex values should be enclosed in parentheses

Otherwise, the expansion can cause operation order problems.

#define EMI_1_BASE (EMI_0_BASE + APPLICATION_ID + 0x1)

Also, what is APPLICATION_ID?