build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32156 )
Change subject: src/security/vboot: Added logic to also verify FSP_S component and syntax change for verify_stage_if_required. ......................................................................
Patch Set 1:
(33 comments)
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c File src/security/vboot/vboot_logic_ex.c:
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 162: if (ENV_POSTCAR) { code indent should use tabs where possible
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 162: if (ENV_POSTCAR) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 163: const struct vb2_id tmp_id = VB2_ID_RAMSTAGE; code indent should use tabs where possible
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 163: const struct vb2_id tmp_id = VB2_ID_RAMSTAGE; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 164: memcpy(id, &tmp_id, sizeof(*id)); code indent should use tabs where possible
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 164: memcpy(id, &tmp_id, sizeof(*id)); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 165: } else if (ENV_RAMSTAGE) { code indent should use tabs where possible
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 165: } else if (ENV_RAMSTAGE) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 168: if (!memcmp(name, CONFIG_CBFS_PREFIX"/payload", code indent should use tabs where possible
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 168: if (!memcmp(name, CONFIG_CBFS_PREFIX"/payload", please, no spaces at the start of a line
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 170: const struct vb2_id tmp_id = VB2_ID_PAYLOAD; code indent should use tabs where possible
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 170: const struct vb2_id tmp_id = VB2_ID_PAYLOAD; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 171: memcpy(id, &tmp_id, sizeof(*id)); code indent should use tabs where possible
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 171: memcpy(id, &tmp_id, sizeof(*id)); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 172: } else if (!memcmp(name, CONFIG_FSP_S_CBFS, code indent should use tabs where possible
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 172: } else if (!memcmp(name, CONFIG_FSP_S_CBFS, please, no spaces at the start of a line
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 174: const struct vb2_id tmp_id = VB2_ID_FSPS; code indent should use tabs where possible
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 174: const struct vb2_id tmp_id = VB2_ID_FSPS; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 175: memcpy(id, &tmp_id, sizeof(*id)); code indent should use tabs where possible
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 175: memcpy(id, &tmp_id, sizeof(*id)); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 176: } code indent should use tabs where possible
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 176: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 177: else code indent should use tabs where possible
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 177: else please, no spaces at the start of a line
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 177: else else should follow close brace '}'
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 178: die("Invalid component"); code indent should use tabs where possible
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 178: die("Invalid component"); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 179: } else code indent should use tabs where possible
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 179: } else please, no spaces at the start of a line
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 180: die("Invalid stage"); code indent should use tabs where possible
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 180: die("Invalid stage"); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 301: rv = verify_hash(&ctx, map, &id); code indent should use tabs where possible
https://review.coreboot.org/#/c/32156/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 301: rv = verify_hash(&ctx, map, &id); please, no spaces at the start of a line