Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31100 )
Change subject: mb/google/hatch: Set up Wake GPIO from EC ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/#/c/31100/3/src/mainboard/google/hatch/Makefile.... File src/mainboard/google/hatch/Makefile.inc:
https://review.coreboot.org/#/c/31100/3/src/mainboard/google/hatch/Makefile.... PS3, Line 28: smm-$(CONFIG_EC_GOOGLE_CHROMEEC) += ec.c Why is this required?
https://review.coreboot.org/#/c/31100/3/src/mainboard/google/hatch/ec.h File src/mainboard/google/hatch/ec.h:
PS3: This file is already present here: https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/hatc...
https://review.coreboot.org/#/c/31100/3/src/mainboard/google/hatch/ec.c File src/mainboard/google/hatch/ec.c:
https://review.coreboot.org/#/c/31100/3/src/mainboard/google/hatch/ec.c@18 PS3, Line 18: "ec.h" <variant/ec.h>
https://review.coreboot.org/#/c/31100/3/src/mainboard/google/hatch/ec.c@26 PS3, Line 26: .s3_device_events = MAINBOARD_EC_S3_DEVICE_EVENTS, Not required.
https://review.coreboot.org/#/c/31100/3/src/mainboard/google/hatch/ec.c@27 PS3, Line 27: .s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS, .s0ix_wake_events =