Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44560 )
Change subject: mb/google/volteer: Add firmware configuration for MAX98373_ALC5682I_I2S_UP4
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44560/5/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/halvor/overridetree.cb:
PS5:
apologies for going a bit beyond the scope of this patch. […]
We went back and forth on that change specifically about making the manual `probe` calls cache as well, and we decided against it. The main point of the fw_config probe statements is to enable/disable devices in the devicetree, so we generate the correct ACPI tables, etc.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44560
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie25f278dfbdc2f41a36b70403699a2e3c2234600
Gerrit-Change-Number: 44560
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Kevin Cheng
kevin.cheng@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 08 Sep 2020 21:49:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment