[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Pass GPIO PM configuration devicetree.cb to ASL

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37794 )

Change subject: soc/intel/cannonlake: Pass GPIO PM configuration devicetree.cb to ASL
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37794/2/src/soc/intel/cannonlake/gp... 
File src/soc/intel/cannonlake/gpio_common.c:

https://review.coreboot.org/c/coreboot/+/37794/2/src/soc/intel/cannonlake/gp... 
PS2, Line 28: 		memset(misccfg_pm_values, MISCCFG_ENABLE_GPIO_PM_CONFIG,
Do we still enable by default? And if we get rid of FSP-S, we can skip overwrite here just write the value that pass by device tree? We can set default in device tree.