Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32701 )
Change subject: arch/cpu: Rename mp_get_apic_id() and add_cpu_map_entry() function ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/32701/2/src/arch/x86/cpu.c File src/arch/x86/cpu.c:
https://review.coreboot.org/#/c/32701/2/src/arch/x86/cpu.c@222 PS2, Line 222: struct cpu_map { Doesn't need to be a struct anymore.
https://review.coreboot.org/#/c/32701/2/src/arch/x86/cpu.c@231 PS2, Line 231: const struct cpu_info *info nit: could just pass only `index`
https://review.coreboot.org/#/c/32701/2/src/arch/x86/cpu.c@233 PS2, Line 233: cpuid_ebx(1) >> 24 Maybe add a function for this? e.g. initial_lapicid()?
https://review.coreboot.org/#/c/32701/2/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/#/c/32701/2/src/cpu/x86/mp_init.c@138 PS2, Line 138: struct cpu_device_map { Doesn't need to be a struct anymore.