[coreboot-gerrit] Change in ...coreboot[master]: mb/siemens/mc_apl1: Enable HDA in devicetree for all mainboard variants

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32295 )

Change subject: mb/siemens/mc_apl1: Enable HDA in devicetree for all mainboard variants
......................................................................

Patch Set 3:
> Patch Set 3: Code-Review+2
>
> We probably would rather not have FSP do unconditional warm resets, but I don't know the background about that API design choice.

It is not that FSP _do_ the warm reset, it is more that it requests it and coreboot performs the warm reset. See https://review.coreboot.org/cgit/coreboot.git/tree/src/drivers/intel/fsp2_0/... line 58
In any case it is not wanted here.