Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40836 )
Change subject: mb/google/dedede: Read DRAM part number from CBI ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40836/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/romstage.c:
https://review.coreboot.org/c/coreboot/+/40836/1/src/mainboard/google/dedede... PS1, Line 37: part_num_state = PART_NUM_NOT_READ;
- Yes, agree with you. […]
Done
https://review.coreboot.org/c/coreboot/+/40836/1/src/mainboard/google/dedede... PS1, Line 53: strlen(part_num_store)
copy that.
Done