16 Dec
2019
16 Dec
'19
7:40 a.m.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37689 )
Change subject: libpayload/drivers/i8042: add error message of i8042_probe ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37689/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/i8042/i8042.c:
https://review.coreboot.org/c/coreboot/+/37689/1/payloads/libpayload/drivers... PS1, Line 201: __func__
Why is __func__ added to this print, but not the rest?
For the 80 char lol. And i8042 should be okay like the log in keyboard.c?
--
To view, visit https://review.coreboot.org/c/coreboot/+/37689
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52039dcab72c6295dfb6b887a7000a6d2bd050ee
Gerrit-Change-Number: 37689
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Mathew King mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 16 Dec 2019 07:40:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment