Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44455 )
Change subject: mb/google/volteer/halvor: Skip fw_config override on Halvor.
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
We should define a new fw_config option for this since it isn't actually the same in the end.
I put a proposal for the volteer program config to add MAX98373_ALC5682I_I2S_UP4 and we can define it in the devicetree.cb here if that gets approved: https://chrome-internal-review.googlesource.com/c/chromeos/program/volteer/+...
Hi Duncan,
We appreciate the comment and CL for configuration on Halvor.
We are going to add the fw_config for Halvor based on the CL and will update result later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44455
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie644ed2b95d0e355f91d92f0b3c4ce14cd4afa98
Gerrit-Change-Number: 44455
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 17 Aug 2020 04:04:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment