Vijay P Hiremath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37870 )
Change subject: soc/intel/tigerlake: Add code for early tcss ......................................................................
Patch Set 29:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37870/28/src/soc/intel/tigerlake/ea... File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/37870/28/src/soc/intel/tigerlake/ea... PS28, Line 40: int req_size may be we can remove this variable in all 3 functions and use macro instead
https://review.coreboot.org/c/coreboot/+/37870/28/src/soc/intel/tigerlake/ea... PS28, Line 103: mux_data.dp_mode ffs(mux_data.dp_mode);
https://review.coreboot.org/c/coreboot/+/37870/28/src/soc/intel/tigerlake/ea... PS28, Line 125: r return here too for error in case of dp?
https://review.coreboot.org/c/coreboot/+/37870/28/src/soc/intel/tigerlake/ea... PS28, Line 182: (uint8_t) remove