Attention is currently required from: Raul Rangel, Martin L Roth, Paul Menzel, Rob Barnes, Karthik Ramasubramanian. Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61259 )
Change subject: soc/amd/cezanne: Turn off gpp clock request for disabled devices ......................................................................
Patch Set 29:
(3 comments)
File src/soc/amd/cezanne/fch.c:
https://review.coreboot.org/c/coreboot/+/61259/comment/3d7bf0f2_c8c9ca3c PS27, Line 159: clk_req
Can we call this `dxio_clk_req` so I don't have to trace where it came from?
Done
https://review.coreboot.org/c/coreboot/+/61259/comment/697e099f_460ed04a PS27, Line 176: -
Is `clk_req == CLK_DISABLE` not valid? Do we want that throwing an assert?
CLK_DISABLE is valid so no assert need, but it did need a continue since CLK_DISABLE doesn't map to a clk req.
https://review.coreboot.org/c/coreboot/+/61259/comment/f63cb64d_33a3b3af PS27, Line 196: if (fw_config_probe_dev(pci_device, &probe)) { : /* : * fw_config probes don't touch the SoC gpp_clk_config. : * So there's only a mismatch if the device was disabled : * by something other than a probe. : */ : printk(BIOS_WARNING, : "GPP clk req mismatch: %d.%d disabled, disabling GPP clk req %d, DXIO descriptor %d\n", : dxio_desc->device_number, : dxio_desc->function_number, gpp_req_index, i); : } else {
Part of me feels like we should just remove this whole chunk.
Done