Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38422 )
Change subject: cbfs: Hook up to new CBFS implmentation ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38422/4/src/lib/cbfs.c File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/38422/4/src/lib/cbfs.c@62 PS4, Line 62: return -1;
Is this to handle that weird case that Ron added in https://review.coreboot. […]
I just copied the existing behavior. Long term I'd prefer to just remove the whole 'type' argument from all these APIs, because I don't think they add anything (the filename already uniquely identifies a file). Callers should be able to explicitly figure out the type if they want to but I don't think they should be forced to pass it for every CBFS access.
For this patch I'd prefer to not change behavior of the API to not conflate any issues arising from that with the rest of the patch. I'm planning to further refactor these APIs later and will then probably remove the type argument completely.