build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34138 )
Change subject: add toshiba satellite u940 initial support ......................................................................
Patch Set 4:
(17 comments)
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... File src/mainboard/toshiba/satellite_u940/mainboard.c:
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 31: /* 00 */ 0x1b, 0x00, 0x00, 0x00, 0x10, 0x19, 0x00, 0x20, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 33: /* 10 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 35: /* 20 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 37: /* 30 */ 0x00, 0x00, 0x00, 0x00, 0x11, 0x00, 0x00, 0x00, 0x00, 0x07, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 39: /* 40 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 41: /* 50 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 43: /* 60 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 45: /* 70 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 47: /* 80 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 49: /* 90 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 51: /* a0 */ 0x00, 0x00, 0x00, 0x84, 0x81, 0x00, 0x00, 0x61, 0x64, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 53: /* b0 */ 0x00, 0x00, 0x00, 0x3a, 0xff, 0x00, 0x00, 0x00, 0x00, 0x07, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 55: /* c0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 57: /* d0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 59: /* e0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 61: /* f0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34138/4/src/mainboard/toshiba/satel... PS4, Line 67: ec_write (i, dmp[i]); space prohibited between function name and open parenthesis '('