[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/chip: Refactor chip_get_common_soc_structure()

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45416 )

Change subject: soc/intel/common/block/chip: Refactor chip_get_common_soc_structure()
......................................................................

soc/intel/common/block/chip: Refactor chip_get_common_soc_structure()

Found-by: Klocwork, Pointer soc_config is used uninitialized.

Signed-off-by: Subrata Banik 
Change-Id: I7e2aa4ef23a68a2ec2ba9d55cf890a7f81e3e278
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45416
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/soc/intel/common/block/chip/chip.c
1 file changed, 1 insertion(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/intel/common/block/chip/chip.c b/src/soc/intel/common/block/chip/chip.c
index 09f2c47..f52d2423 100644
--- a/src/soc/intel/common/block/chip/chip.c
+++ b/src/soc/intel/common/block/chip/chip.c
@@ -1,15 +1,8 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

-#include <soc/pci_devs.h>
 #include <soc/soc_chip.h>

const struct soc_intel_common_config *chip_get_common_soc_structure(void)
 {
-	const struct soc_intel_common_config *soc_config;
-	const config_t *config;
-
-	config = config_of_soc();
-	soc_config = &config->common_soc_config;
-
-	return soc_config;
+	return &((config_t *)config_of_soc())->common_soc_config;
 }