[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add generic SMU service request

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41625 )

Change subject: soc/amd/picasso: Add generic SMU service request
......................................................................

Patch Set 3:

(4 comments)

https://review.coreboot.org/c/coreboot/+/41625/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41625/1//COMMIT_MSG@13 
PS1, Line 13: used
> used to

Done

https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/include... 
File src/soc/amd/picasso/include/soc/smu.h:

https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/include... 
PS1, Line 30: int
> Use CB_SUCCESS and friends?

Done

https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/include... 
PS1, Line 33: put
> to put

Done

https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c 
File src/soc/amd/picasso/smu.c:

https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c@4... 
PS1, Line 46: int
> unsigned

Done