John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32903 )
Change subject: soc/intel/apollolake: Fix value stored to gnvs is never read
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32903/2/src/soc/intel/apollolake/chip.c
File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/#/c/32903/2/src/soc/intel/apollolake/chip.c@a421
PS2, Line 421:
gnvs is used by other blocks in common code as well e.g. uart. […]
The order appears soc_init->uart->southbridge_inject_dsdt. While enabling uart resources, uart refers to GNVS in CBMEM. Since *gnvs is never used here, just changing sizeof(*gnvs) to sizeof(global_nvs_t).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32903
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9421af4a556d1d88183aa938ee2a124a10ab727
Gerrit-Change-Number: 32903
Gerrit-PatchSet: 5
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jacob Garber
jgarber1@ualberta.ca
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 May 2019 01:30:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment