[coreboot-gerrit] [M] Change in coreboot[main]: drivers/amd/opensil/memmap.c: Factor out common memmap code to driver

[Felix Held (Code Review)]

Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Nick Kochlowski, Varshit Pandya.

Felix Held has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85634?usp=email )

Change subject: drivers/amd/opensil/memmap.c: Factor out common memmap code to driver
......................................................................

Patch Set 20:

(1 comment)

File src/drivers/amd/opensil/memmap.c:

https://review.coreboot.org/c/coreboot/+/85634/comment/d91109c0_46578f6e?usp... :
PS20, Line 36: 	if (top_of_mem <= 4ULL * GiB)
this check needs to be after the opensil_get_hole_info call; right now this is always true.
my guess why this worked with the old code is that i'd assume that print_memory_holes (which calls get_hole_info which updates the global top_of_mem variable) gets called before add_opensil_memmap