Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47640 )
Change subject: drivers/i2c: Add a driver for Semtech SX9324
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47640/2/src/drivers/i2c/sx9324/sx93...
File src/drivers/i2c/sx9324/sx9324.c:
https://review.coreboot.org/c/coreboot/+/47640/2/src/drivers/i2c/sx9324/sx93...
PS2, Line 75: D%03.3X
Done
Could be more than one... there is a potential use-case for a SAR for WiFi and a SAR for LTE, so if they're on the same I2C bus, we'd have a name conflict then.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47640
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd582482728a2f535ed85f6696b2f5a4529ba421
Gerrit-Change-Number: 47640
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 17 Nov 2020 20:45:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment