Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58903 )
Change subject: mb/purism/librem_skl: Clean up hda_verb.c ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
oh, wait, i mixed up 12AM and 12PM and submitted this patch series a bit too early. […]
Don't worry, we all make mistakes sometimes 😊
I'm positive that this patch train shouldn't cause any issues: the last three commits are reproducible and the first one is a one-liner that is most likely reproducible as well (I didn't test it).
There's a rule in our Gerrit guidelines [1] that allows "trivial" changes that don't affect the final binary output (there's a different rule for emergency fixes) to be submitted early if:
1. the commit message should point out how reproducibility was tested 2. the submitter must be different from the authors 3. the submitter must document their intent in the Gerrit discussion
This rule isn't meant to be used frequently, just in cases where submitting a trivial change early is useful for some reason. For example, one can submit a trivial change before making a complicated patch train to avoid having to manually rebase the train after the trivial change got merged.
I prefer not to use this rule. I hardly ever have a reason to use it, and post-merge discussion can be somewhat bitter in rare cases (e.g. when pushing the meaning of "trivial" to its limits). However, I find it very useful to assess accidental early submissions.
In this case, I wouldn't have used this rule to *intentionally* submit these changes early, but I'm not mad, worried, upset or anything remotely similar that they were submitted early because of a confusing time format.
TL;DR: Nothing to worry about, just me being highly inspired today 😄
[1]: https://doc.coreboot.org/getting_started/gerrit_guidelines.html