Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43397 )
Change subject: soc/intel/skylake: Add necessary FSPT params when FSP CAR is used
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43397/1/src/soc/intel/skylake/bootb...
File src/soc/intel/skylake/bootblock/fspcar.c:
https://review.coreboot.org/c/coreboot/+/43397/1/src/soc/intel/skylake/bootb...
PS1, Line 26: CONFIG_ROM_SIZE
that explodes if CONFIG_ROM_SIZE > 16MiB
True. Any suggestions to resolve it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43397
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b3f770bd56ca072bebb485c02e1022ba95c6e4c
Gerrit-Change-Number: 43397
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Mon, 13 Jul 2020 09:17:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment