Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37328 )
Change subject: sb/amd/cimx: replace cimx_util with common ACPIMMIO AMD block
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37328/1/src/mainboard/amd/inagua/ma...
File src/mainboard/amd/inagua/mainboard.c:
https://review.coreboot.org/c/coreboot/+/37328/1/src/mainboard/amd/inagua/ma...
PS1, Line 66: pm_write8(0x29, 0x80);
Checked that already in RRG and it is enabled in the southbridge initialization in romcc bootblock
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37328
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66b1f82926372b6ebb570893b6eb73c7f2935b9d
Gerrit-Change-Number: 37328
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Dec 2019 02:50:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment