Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31082 )
Change subject: amd/stoneyridge: Disable GPIO MASK STATUS ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31082/1/src/soc/amd/stoneyridge/gpio.c File src/soc/amd/stoneyridge/gpio.c:
https://review.coreboot.org/#/c/31082/1/src/soc/amd/stoneyridge/gpio.c@267 PS1, Line 267:
Per https://www.coreboot.org/Developer_Manual (which may be of date?), coreboot uses linux […]
Done
https://review.coreboot.org/#/c/31082/1/src/soc/amd/stoneyridge/gpio.c@344 PS1, Line 344: will
s/will/may
Done
https://review.coreboot.org/#/c/31082/1/src/soc/amd/stoneyridge/include/soc/... File src/soc/amd/stoneyridge/include/soc/gpio.h:
https://review.coreboot.org/#/c/31082/1/src/soc/amd/stoneyridge/include/soc/... PS1, Line 45: #define MASK_STATUS_SHIFT 28
Hmm, perhaps stick closer to the BKDG names? […]
Done