16 Mar
2020
16 Mar
'20
2:10 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23585 )
Change subject: libpayload/drivers/nvram: Add function to write RTC ......................................................................
Patch Set 7: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/23585/7/payloads/libpayload/drivers... File payloads/libpayload/drivers/nvram.c:
https://review.coreboot.org/c/coreboot/+/23585/7/payloads/libpayload/drivers... PS7, Line 185: !(statusB & NVRAM_RTC_FORMAT_BINARY) Maybe place this check inside a wrapper for nvram_write()? That way, the writes don't have to be duplicated
--
To view, visit https://review.coreboot.org/c/coreboot/+/23585
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17b4c1ee0dcc649738ac6a7400b087d07213eaf0
Gerrit-Change-Number: 23585
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 16 Mar 2020 09:10:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment