Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40579 )
Change subject: vboot: Add permission check for kernel space ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40579/3/src/security/vboot/secdata_... File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/40579/3/src/security/vboot/secdata_... PS3, Line 72: #if !CONFIG(TPM2)
Please write this in C instead (i.e. 'if (CONFIG(TPM2)) {...}').
That requires TPM_NV_PER_PPWRITE to be defined for TPM2 as well. Do you still want it?
https://review.coreboot.org/c/coreboot/+/40579/3/src/security/vboot/secdata_... PS3, Line 82: TlclGetPermissions
Hmm, crap, it looks like TlclGetPermissions() was never ported to coreboot, so you'll have to do tha […]
Done