Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39918 )
Change subject: soc/intel/xeon_sp/cpx: Enable SATA ports
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39918/2/src/soc/intel/xeon_sp/cpx/K...
File src/soc/intel/xeon_sp/cpx/Kconfig:
https://review.coreboot.org/c/coreboot/+/39918/2/src/soc/intel/xeon_sp/cpx/K...
PS2, Line 20: SOC_INTEL_COMMON_BLOCK_SATA
It seems to me that the mask in the common code https://github. […]
good catch. I guess we will have add that logic (number of ports) directly in block/sata/sata.c, since it looks like it is not possible to figure out hardware capabilities run-time. I will work on a patch for this
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39918
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba8f8c8812168deace1abaa7cf3996b870648686
Gerrit-Change-Number: 39918
Gerrit-PatchSet: 2
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Maxim Polyakov
m.poliakov@yahoo.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Name of user not set #1002872
Gerrit-Comment-Date: Tue, 31 Mar 2020 05:40:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-MessageType: comment