[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/common: Show "Add gigabit ethernet firmware" only for boards...

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30790 )

Change subject: sb/intel/common: Show "Add gigabit ethernet firmware" only for boards that need it
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/30790/1/src/mainboard/siemens/mc_bdx1/Kconfi... 
File src/mainboard/siemens/mc_bdx1/Kconfig:

https://review.coreboot.org/#/c/30790/1/src/mainboard/siemens/mc_bdx1/Kconfi... 
PS1, Line 17: MAINBOARD_USES_IFD_GBE_REGION
> Well just for this board I would like to not add this switch as we do not use the internal GBE contr […]

Right, consider disabling the GbE controller in the devicetree (line 8): https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/siemens/mc_...