Attention is currently required from: Patrick Rudolph, Angel Pons, Aaron Durbin.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52784 )
Change subject: arch/x86: Fix !CONFIG_VBOOT_SEPARATE_VERSTAGE
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52784/comment/b32222af_c8ca1bc3
PS1, Line 7: arch/x86: Fix !CONFIG_VBOOT_SEPARATE_VERSTAGE
Specifically, `VBOOT_STARTS_IN_BOOTBLOCK && !VBOOT_SEPARATE_VERSTAGE` is what fails to build.
VBOOT_SEPARATE_VERSTAGE assumes VBOOT_STARTS_IN_BOOTBLOCK.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52784
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1227feab9ffbbc06e614f297be44fb67f13bda42
Gerrit-Change-Number: 52784
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Fri, 30 Apr 2021 13:37:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment