Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37637 )
Change subject: acpigen: Add methods for mutex operations
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37637/1/src/arch/x86/acpigen.c
File src/arch/x86/acpigen.c:
https://review.coreboot.org/c/coreboot/+/37637/1/src/arch/x86/acpigen.c@426
PS1, Line 426: acpigen_write_word(val);
it has to be emit_word()
hm, i got my information from ACPI 6_2_A_Sept29.pdf 19.6.2 Acquire (Acquire a Mutex), but since you've tested that, i'd say that your code is correct here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37637
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79310b0f9e2297cf8428d11598935164caf95968
Gerrit-Change-Number: 37637
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 11 Dec 2019 20:11:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment