Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38349 )
Change subject: util/pmh7tool: Support OpenBSD ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38349/1/util/pmh7tool/Makefile File util/pmh7tool/Makefile:
https://review.coreboot.org/c/coreboot/+/38349/1/util/pmh7tool/Makefile@22 PS1, Line 22: ifeq ($(shell uname -s 2>/dev/null), OpenBSD)
The redirection after 'uname -s', is that required or is it a security consideration?
It was just used in other utils (nvramtool, ectool) in similar cases. I don't see any difference when it's removed.
https://review.coreboot.org/c/coreboot/+/38349/2/util/pmh7tool/pmh7tool.c File util/pmh7tool/pmh7tool.c:
https://review.coreboot.org/c/coreboot/+/38349/2/util/pmh7tool/pmh7tool.c@33 PS2, Line 33: __asm volatile("inb %w1,%0" : "=a" (data) : "d" (port));
Prefer using '"%s... […]
I'm not sure how to fix these or should these be fixed at all.