View Change

2 comments:

• File util/pmh7tool/Makefile:

  • Patch Set #1, Line 22: ifeq ($(shell uname -s 2>/dev/null), OpenBSD)

    The redirection after 'uname -s', is that required or is it a security consideration?

    It was just used in other utils (nvramtool, ectool) in similar cases. I don't see any difference when it's removed.

• File util/pmh7tool/pmh7tool.c:

  • Patch Set #2, Line 33: __asm volatile("inb %w1,%0" : "=a" (data) : "d" (port));

    Prefer using '"%s... […]

    I'm not sure how to fix these or should these be fixed at all.

To view, visit change 38349. To unsubscribe, or for help writing mail filters, visit settings.