Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43796 )
Change subject: soc/mediatek/mt8183: Transfer ddr geometry type to dram blob ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43796/12/src/soc/mediatek/mt8183/me... File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/43796/12/src/soc/mediatek/mt8183/me... PS12, Line 100: ) since you only need geometry, we should change this to
static int dram_run_...(..., u32 ddr_geometry, u16 config) {
... dram->freq_params[0].ddr_geometry = ddr_geometry;
https://review.coreboot.org/c/coreboot/+/43796/12/src/soc/mediatek/mt8183/me... PS12, Line 188: } given sdram_config is needed by both full-k and partial-k, we should read it here:
const struct sdram_params *sdram_cfg = get_sdram_config();
And then pas sdram_cfg->ddr_geometry when calling dram_full_full_calibration.