Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42205 )
Change subject: mb/google/dedede: Add ACPI support for camera in waddledee
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42205/9/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/waddledee/include/variant/acpi/cam0.asl:
https://review.coreboot.org/c/coreboot/+/42205/9/src/mainboard/google/dedede...
PS9, Line 36: Sleep(5) /* 5 us */
So all of the comments in here for the Sleeps say `us` implying microseconds, but the ASL Sleep op sleeps for *milliseconds*. So are the comments wrong, or do you actually only need to sleep for 5 us? Because the finest granularity is the 1ms of Sleep, so a Sleep(1) would be the best you could do.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42205
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f6b490832d2c34c86512384eb7470f13a212a66
Gerrit-Change-Number: 42205
Gerrit-PatchSet: 9
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt Delco
delco@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Comment-Date: Wed, 08 Jul 2020 19:07:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment