Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46480 )
Change subject: vc/intel/FSP2_0/CPX-SP: add FSPM DIMM watermark option
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46480/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46480/5//COMMIT_MSG@10
PS5, Line 10: FSP binary, but not in Intel's CPX-SP FSP binary.
Do we want to support such inconsistencies in coreboot? I think coreboot should only support one typ […]
We do not want to and we want to minimize the difference. That being said, this become unavoidable. Since Intel CPX-SP FSP binary is not released yet, and since FB is probably the only Intel customer who uses CPX-SP FSP binary, we could go with not adding a Kconfig, and not do conditional compilation at this time. But sooner or later we will need to deal with such situation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46480
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7592dfc8836f457d64f1976cba3b59f8251c7abe
Gerrit-Change-Number: 46480
Gerrit-PatchSet: 5
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 19 Oct 2020 21:32:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment