[coreboot-gerrit] Change in ...coreboot[master]: mainboard/google/sarien: set diagnostic LEDs on boot failure

[Keith Short (Code Review)]

Keith Short has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32777

Change subject: mainboard/google/sarien: set diagnostic LEDs on boot failure
......................................................................

mainboard/google/sarien: set diagnostic LEDs on boot failure

On Wilco devices, if any of the coreboot stages fails with a fatal
error, set the diagnostic LEDs with the Wilco EC.

BUG=b:124401932
BRANCH=sarien
TEST=build coreboot for sarien and arcada platforms
TEST=Remove DIMM module, confirm diagnostic LED pattern for memory
failure (2 amber, 4 white).
TEST=Forced a fatal error in both bootblock and verstage to confirm
diagnostic LEDs during these stages. This works on cold-boots only. Bug
b:132622888 tracks the mailbox failures on warm boots.

Change-Id: If865ab8203f89e499130f4677fec166b40d80174
Signed-off-by: Keith Short 
---
M src/mainboard/google/sarien/chromeos.c
1 file changed, 42 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/32777/1

diff --git a/src/mainboard/google/sarien/chromeos.c b/src/mainboard/google/sarien/chromeos.c
index fafc469..d6b34f9 100644
--- a/src/mainboard/google/sarien/chromeos.c
+++ b/src/mainboard/google/sarien/chromeos.c
@@ -15,22 +15,41 @@

#include <arch/acpi.h>
 #include <boot/coreboot_tables.h>
+#include <console/console.h>
 #include <gpio.h>
 #include <soc/gpio.h>
 #include <variant/gpio.h>
 #include <vendorcode/google/chromeos/chromeos.h>
 #include <security/tpm/tss.h>
 #include <device/device.h>
+#include <ec/google/wilco/commands.h>
 #include <intelblocks/pmclib.h>
 #include <soc/pmc.h>
 #include <soc/pci_devs.h>

+struct err_code_entry {
+	uint8_t post_code;
+	enum ec_err_code ec_err;
+};
+
 enum rec_mode_state {
    REC_MODE_UNINITIALIZED,
    REC_MODE_NOT_REQUESTED,
    REC_MODE_REQUESTED,
 };

+static uint8_t sarien_post_code;
+
+/*
+ * Any post codes not listed in the sarien_err_codes[] use this default.
+ */
+static const enum ec_err_code sarien_default_ec_err = DLED_ROM;
+static const struct err_code_entry sarien_err_codes[] = {
+	{ .post_code = POST_RAM_FAILURE, .ec_err = DLED_MEMORY, },
+	{ .post_code = POST_VIDEO_FAILURE, .ec_err = DLED_PANEL, },
+};
+
+
 void fill_lb_gpios(struct lb_gpios *gpios)
 {
    struct lb_gpio chromeos_gpios[] = {
@@ -125,3 +144,26 @@
    pmc_set_afterg3(PCH_DEV_PMC, MAINBOARD_POWER_STATE_ON);
 #endif
 }
+
+void mainboard_post(uint8_t value)
+{
+	sarien_post_code = value;
+}
+
+void die_notify(void)
+{
+	size_t i;
+	enum ec_err_code ec_err = sarien_default_ec_err;
+
+	for (i = 0; i < ARRAY_SIZE(sarien_err_codes); i++) {
+		if (sarien_err_codes[i].post_code == sarien_post_code) {
+			ec_err = sarien_err_codes[i].ec_err;
+			break;
+		}
+	}
+
+	printk(BIOS_EMERG, "Fatal error: post_code 0x%02x, EC err 0x%02x\n",
+		sarien_post_code, ec_err);
+
+	wilco_ec_err_code(ec_err);
+}