Attention is currently required from: Lance Zhao, Nico Huber, Tim Wawrzynczak, Maximilian Brune, Lean Sheng Tan, Werner Zeh, Jan Samek.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74762 )
Change subject: acpi: Add a runtime method to override exposed _Sx sleep states
......................................................................
Patch Set 7:
(1 comment)
File src/acpi/acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174988):
https://review.coreboot.org/c/coreboot/+/74762/comment/d86616be_728eb1c6
PS7, Line 521: void acpi_ssdt_override_sleep_states(uint8_t enable_s1, uint8_t enable_s2, uint8_t enable_s3, uint8_t enable_s4)
line length of 112 exceeds 107 columns
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74762
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic21830c1ef9c183b1e3005cc1f8b7daf7e9ea998
Gerrit-Change-Number: 74762
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Jan Samek
jan.samek@siemens.com
Gerrit-Comment-Date: Wed, 26 Apr 2023 06:56:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment