13 Nov
2019
13 Nov
'19
4:50 p.m.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... PS2, Line 132: 12000
Limit CPU power from 15Walt to 12Walt. […]
The point is that the TDP should be somewhere between the min and max PL1 values, right now you have TDP at 15W, but PL1 can range from 3W to (now) 12W, which doesn't make sense.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36716
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0e6d93e1fc0c684e067d1450eb119a53cfefaed
Gerrit-Change-Number: 36716
Gerrit-PatchSet: 5
Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Ben Kao ben.kao@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Marx Wang marx.wang@intel.com
Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Philip Chen philipchen@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 13 Nov 2019 16:50:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peichao Li peichao.wang@bitland.corp-partner.google.com
Gerrit-MessageType: comment